Skip to content

bugfix(fxlist): Fix unreliable terrain layer selection of particles using CreateAtGroundHeight #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 2 commits into from
Jul 23, 2026
Merged

bugfix(fxlist): Fix unreliable terrain layer selection of particles using CreateAtGroundHeight #3004

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cddf486
bugfix(fxlist): Fix unreliable terrain layer selection of particles u…
stephanmeesters Jul 22, 2026
11ddc42
Process review comment
stephanmeesters Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Core/GameEngine/Source/GameClient/FXList.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,6 +614,7 @@ class ParticleSystemFXNugget : public FXNugget

newPos.x = primary->x + offset.x + radius * cos(angle);
newPos.y = primary->y + offset.y + radius * sin(angle);
newPos.z = primary->z + offset.z;
if( m_createAtGroundHeight && TheTerrainLogic )
{
//old way:
Expand All @@ -624,7 +625,7 @@ class ParticleSystemFXNugget : public FXNugget
newPos.z = TheTerrainLogic->getLayerHeight( newPos.x, newPos.y, layer );
}
else
newPos.z = primary->z + offset.z + m_height.getValue();
newPos.z += m_height.getValue();


if (m_orientToObject && mtx)
Expand Down
Loading