Skip to content

chore: Remove redundant void argument from functions (3) - #3027

Open
CryoTheRenegade wants to merge 2 commits into
TheSuperHackers:mainfrom
CryoTheRenegade:refactor/remove-remaining-redundant-void-arguments
Open

chore: Remove redundant void argument from functions (3)#3027
CryoTheRenegade wants to merge 2 commits into
TheSuperHackers:mainfrom
CryoTheRenegade:refactor/remove-remaining-redundant-void-arguments

Conversation

@CryoTheRenegade

@CryoTheRenegade CryoTheRenegade commented Jul 28, 2026

Copy link
Copy Markdown

Removed 1,791 redundant sole-void parameter lists from C++ declarations and definitions across 308 files, including tool sources not covered by the Visual Studio solution.

@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown

Greptile Summary

The PR performs a mechanical C++ refactor across shared libraries and standalone tools.

  • Replaces sole void parameter lists with equivalent empty parameter lists in declarations, definitions, constructors, destructors, operators, and macro arguments.
  • Applies the refactor across 310 files without changing function bodies, control flow, or data contracts.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
Core/Libraries/Source/debug/debug_stack.inl Updates the SymGetOptions debug-helper macro signature from (void) to the C++-equivalent ().
Core/Tools/Autorun/autorun.cpp Mechanically modernizes no-argument declarations and definitions without changing executable behavior.
Core/Tools/Babylon/TransDB.h Rewrites no-argument member signatures while preserving their types and qualifiers.
Core/Tools/WW3D/max2w3d/w3dappdata.h Removes redundant void parameter tokens from the exporter API without changing its interface semantics.
GeneralsMD/Code/Tools/WorldBuilder/include/TeamObjectProperties.h Modernizes no-argument WorldBuilder member declarations and inline definitions with no behavioral change.

Reviews (4): Last reviewed commit: "refactor: Remove more instances of void ..." | Re-trigger Greptile

@CryoTheRenegade
CryoTheRenegade force-pushed the refactor/remove-remaining-redundant-void-arguments branch from 5de469a to 5f4ede8 Compare July 29, 2026 01:13

@Skyaero42 Skyaero42 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One point of attention, the rest looks fine.

Comment thread Core/Libraries/Source/debug/debug_stack.inl
@Caball009

Copy link
Copy Markdown

I searched for regex \(\s*void\s*\) and found a couple more, so I've taken the liberty to push them to your branch.

@CryoTheRenegade

Copy link
Copy Markdown
Author

I searched for regex \(\s*void\s*\) and found a couple more, so I've taken the liberty to push them to your branch.

Thanks!

@CryoTheRenegade
CryoTheRenegade force-pushed the refactor/remove-remaining-redundant-void-arguments branch from 97db682 to a4c6b8d Compare July 29, 2026 16:11
@Caball009 Caball009 added the Refactor Edits the code with insignificant behavior changes, is never user facing label Jul 29, 2026
@xezon xezon changed the title refactor(cpp): Remove redundant void parameter lists refactor: Remove redundant void argument from functions (3) Jul 29, 2026
@xezon xezon changed the title refactor: Remove redundant void argument from functions (3) chore: Remove redundant void argument from functions (3) Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Edits the code with insignificant behavior changes, is never user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove remaining cases of redundant void argument from functions

4 participants