bugfix: All USA Pilot variants no longer move 16.67% slower at Heroic rank

[Stubbjax]

This change fixes an issue where all USA Pilot variants would move 16.67% slower after reaching Heroic rank.

The original 1.04 behaviour can be seen below:

PILOTS.mp4

[xezon]

It looks like the intent here was that it would move 25% faster when Hero.

; basically the same as BasicHumanLocomotor, but roughly 25% faster
Locomotor BasicHumanLocomotorPlus25
  Speed = 25.0 ; in dist/sec
  SpeedDamaged = 12.0 ; in dist/sec
End

Now the question is WHY is it slower instead? It's strange? Is it a code bug?

I think we first need to decide what the expected design is. Should it walk unchanged or faster when Hero? Maybe make a vote at Committee?

[Stubbjax]

It's likely an old design where the Pilot ran faster once it reached Heroic rank. I imagine a subsequent design tweak upped the original speed and made the upgraded speed redundant.

I don't think it matters what the original intention was anymore and I imagine most would vote for the current proposal.

[xezon]

It still does not explain why it walks lower if it is setup to walk faster. Is there a code bug? Why does it happen?

I vote for Committee Vote.

[Stubbjax]

It happens because a pre-release setup would have looked like this:

Locomotor = SET_NORMAL BasicHumanLocomotor
Locomotor = SET_NORMAL_UPGRADED BasicHumanLocomotorPlus25

Which would result in a base speed of 20 and upgraded speed of 25. Designers probably suggested it was too slow and so it got increased, but the Heroic rank speed was not immediately visible and thus forgotten. It doesn't make intuitive sense that a Pilot runs faster with more vehicular experience anyway.

[xezon]

Oh ok I just see now it uses the ColonelBurtonGroundLocomotor. I thought it was BasicHumanLocomotor.

Ok then your fix makes sense.

[xezon]

Can add unused comment to BasicHumanLocomotorPlus25 definition

[Stubbjax]

Do we want to do that if we're likely to eventually use it again? We changed Hackers to use it in Patch1 and I had a proposal to have Pathfinders use it too.

[xezon]

Up to you. But do not remove it, to not break Mod maps that use it.