Skip to content

bugfix: All USA Pilot variants no longer move 16.67% slower at Heroic rank #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stubbjax merged 1 commit into from
Aug 2, 2026
Merged

bugfix: All USA Pilot variants no longer move 16.67% slower at Heroic rank #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions Generals/Data/INI/Object/Campaign/America/Unit/CINE_AmericaInfantryPilot.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,16 +161,11 @@ Object CINE_AmericaInfantryPilot
End

Locomotor = SET_NORMAL ColonelBurtonGroundLocomotor
Locomotor = SET_NORMAL_UPGRADED BasicHumanLocomotorPlus25

@xezon xezon Jul 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add unused comment to BasicHumanLocomotorPlus25 definition

@Stubbjax Stubbjax Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to do that if we're likely to eventually use it again? We changed Hackers to use it in Patch1 and I had a proposal to have Pathfinders use it too.

@xezon xezon Jul 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you. But do not remove it, to not break Mod maps that use it.


Behavior = PhysicsBehavior ModuleTag_08
Mass = 5.0
End

Behavior = LocomotorSetUpgrade ModuleTag_10
TriggeredBy = Upgrade_Veterancy_HEROIC
End

Behavior = SquishCollide ModuleTag_11
; <NO DATA>
End
Expand Down
5 changes: 0 additions & 5 deletions Generals/Data/INI/Object/Faction/America/Unit/AmericaInfantryPilot.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,16 +153,11 @@ Object AmericaInfantryPilot
End

Locomotor = SET_NORMAL ColonelBurtonGroundLocomotor
Locomotor = SET_NORMAL_UPGRADED BasicHumanLocomotorPlus25

Behavior = PhysicsBehavior ModuleTag_08
Mass = 5.0
End

Behavior = LocomotorSetUpgrade ModuleTag_10
TriggeredBy = Upgrade_Veterancy_HEROIC
End

Behavior = SquishCollide ModuleTag_11
; <NO DATA>
End
Expand Down
5 changes: 0 additions & 5 deletions GeneralsZH/Data/INI/Object/Campaign/America/Unit/CINE_AmericaInfantryPilot.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,16 +157,11 @@ Object CINE_AmericaInfantryPilot
End

Locomotor = SET_NORMAL ColonelBurtonGroundLocomotor
Locomotor = SET_NORMAL_UPGRADED BasicHumanLocomotorPlus25

@xezon xezon Jul 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the intent here was that it would move 25% faster when Hero.

; basically the same as BasicHumanLocomotor, but roughly 25% faster
Locomotor BasicHumanLocomotorPlus25
  Speed = 25.0 ; in dist/sec
  SpeedDamaged = 12.0 ; in dist/sec
End

Now the question is WHY is it slower instead? It's strange? Is it a code bug?

I think we first need to decide what the expected design is. Should it walk unchanged or faster when Hero? Maybe make a vote at Committee?

@Stubbjax Stubbjax Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's likely an old design where the Pilot ran faster once it reached Heroic rank. I imagine a subsequent design tweak upped the original speed and made the upgraded speed redundant.

I don't think it matters what the original intention was anymore and I imagine most would vote for the current proposal.

@xezon xezon Jul 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still does not explain why it walks lower if it is setup to walk faster. Is there a code bug? Why does it happen?

I vote for Committee Vote.

@Stubbjax Stubbjax Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It happens because a pre-release setup would have looked like this:

Locomotor = SET_NORMAL BasicHumanLocomotor
Locomotor = SET_NORMAL_UPGRADED BasicHumanLocomotorPlus25

Which would result in a base speed of 20 and upgraded speed of 25. Designers probably suggested it was too slow and so it got increased, but the Heroic rank speed was not immediately visible and thus forgotten. It doesn't make intuitive sense that a Pilot runs faster with more vehicular experience anyway.

@xezon xezon Jul 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok I just see now it uses the ColonelBurtonGroundLocomotor. I thought it was BasicHumanLocomotor.

Ok then your fix makes sense.


Behavior = PhysicsBehavior ModuleTag_08
Mass = 5.0
End

Behavior = LocomotorSetUpgrade ModuleTag_10
TriggeredBy = Upgrade_Veterancy_HEROIC
End

Behavior = SquishCollide ModuleTag_11
; <NO DATA>
End
Expand Down
5 changes: 0 additions & 5 deletions GeneralsZH/Data/INI/Object/Faction/America/Unit/AmericaInfantryPilot.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,16 +153,11 @@ Object AmericaInfantryPilot
End

Locomotor = SET_NORMAL ColonelBurtonGroundLocomotor
Locomotor = SET_NORMAL_UPGRADED BasicHumanLocomotorPlus25

Behavior = PhysicsBehavior ModuleTag_08
Mass = 5.0
End

Behavior = LocomotorSetUpgrade ModuleTag_10
TriggeredBy = Upgrade_Veterancy_HEROIC
End

Behavior = SquishCollide ModuleTag_11
; <NO DATA>
End
Expand Down
5 changes: 0 additions & 5 deletions GeneralsZH/Data/INI/Object/Faction/AmericaAirForce/Unit/AirF_AmericaInfantryPilot.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,16 +153,11 @@ Object AirF_AmericaInfantryPilot
End

Locomotor = SET_NORMAL ColonelBurtonGroundLocomotor
Locomotor = SET_NORMAL_UPGRADED BasicHumanLocomotorPlus25

Behavior = PhysicsBehavior ModuleTag_08
Mass = 5.0
End

Behavior = LocomotorSetUpgrade ModuleTag_10
TriggeredBy = Upgrade_Veterancy_HEROIC
End

Behavior = SquishCollide ModuleTag_11
; <NO DATA>
End
Expand Down
5 changes: 0 additions & 5 deletions GeneralsZH/Data/INI/Object/Faction/AmericaLaser/Unit/Lazr_AmericaInfantryPilot.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,16 +153,11 @@ Object Lazr_AmericaInfantryPilot
End

Locomotor = SET_NORMAL ColonelBurtonGroundLocomotor
Locomotor = SET_NORMAL_UPGRADED BasicHumanLocomotorPlus25

Behavior = PhysicsBehavior ModuleTag_08
Mass = 5.0
End

Behavior = LocomotorSetUpgrade ModuleTag_10
TriggeredBy = Upgrade_Veterancy_HEROIC
End

Behavior = SquishCollide ModuleTag_11
; <NO DATA>
End
Expand Down
5 changes: 0 additions & 5 deletions GeneralsZH/Data/INI/Object/Faction/AmericaSuperWeapon/Unit/SupW_AmericaInfantryPilot.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,16 +152,11 @@ Object SupW_AmericaInfantryPilot
End

Locomotor = SET_NORMAL ColonelBurtonGroundLocomotor
Locomotor = SET_NORMAL_UPGRADED BasicHumanLocomotorPlus25

Behavior = PhysicsBehavior ModuleTag_08
Mass = 5.0
End

Behavior = LocomotorSetUpgrade ModuleTag_10
TriggeredBy = Upgrade_Veterancy_HEROIC
End

Behavior = SquishCollide ModuleTag_11
; <NO DATA>
End
Expand Down