Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/remove unnecessary import #3682

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Fix/remove unnecessary import #3682

merged 5 commits into from
Apr 16, 2024

Conversation

freeboub
Copy link
Collaborator

Summary

remove unnecessary import:

Motivation

fix: #3622

Changes

remove include

Test plan

build on CI

@freeboub freeboub requested a review from KrzysztofMoch April 16, 2024 12:14
KrzysztofMoch
KrzysztofMoch approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@KrzysztofMoch KrzysztofMoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I was also looking into it but I was able to find why in was added - it seems to work so let's merge this

@KrzysztofMoch KrzysztofMoch merged commit a0bcdb7 into TheWidlarzGroup:master Apr 16, 2024
6 checks passed
@KrzysztofMoch
Copy link
Member

if there will be any issue we will revert

@honzajerabek honzajerabek mentioned this pull request Sep 5, 2024
Closed
@mid2ly mid2ly mentioned this pull request Oct 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrzysztofMoch KrzysztofMoch KrzysztofMoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Duplicate interface definition for class 'RCTEventDispatcher'
2 participants
@freeboub @KrzysztofMoch