[Merged by Bors] - Define rand defaults for AbstractProbabilisticProgram #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
reviewed
Feb 24, 2023
Co-authored-by: David Widmann <[email protected]>
|
This code should also be backported to v0.5 |
|
For now, I think we can just implement the new |
|
bors r+ |
|
👎 Rejected by too few approved reviews |
sunxd3
approved these changes
Feb 25, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 25, 2023
This PR adds a 3-arg form of `rand` (suggested by @devmotion in TuringLang/DynamicPPL.jl#466 (comment)) to the interface for `AbstractProbabilisticProgram` and implements the default 1- and 2-arg methods that dispatch to this. Currently tests fail because this breaks the fallbacks for `GraphPPL.Model`, which expects `rand` to forward to its `rand!` method. I'm not certain how we want to define the interface for this `Model`. Co-authored-by: Xianda Sun <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a 3-arg form of
rand(suggested by @devmotion in TuringLang/DynamicPPL.jl#466 (comment)) to the interface forAbstractProbabilisticProgramand implements the default 1- and 2-arg methods that dispatch to this.Currently tests fail because this breaks the fallbacks for
GraphPPL.Model, which expectsrandto forward to itsrand!method. I'm not certain how we want to define the interface for thisModel.