Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Bijectors version to 0.14 #701

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Bump Bijectors version to 0.14 #701

merged 2 commits into from
Nov 6, 2024

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Oct 29, 2024

Bijectors v0.14.0 allows us to once again have an environment with Bijectors + Enzyme on Julia 1.11.

This PR, which lets DynamicPPL make use of Bijectors 0.14.0, will in turn allow us to have an environment with DynamicPPL + Enzyme on Julia 1.11.

Closes #706 Closes #707

@penelopeysm penelopeysm changed the title Bump Bijectors version Bump Bijectors version to 0.14 Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (b96e368) to head (c99944b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #701   +/-   ##
=======================================
  Coverage   82.14%   82.14%           
=======================================
  Files          30       30           
  Lines        4200     4200           
=======================================
  Hits         3450     3450           
  Misses        750      750           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Oct 29, 2024

Pull Request Test Coverage Report for Build 11702634433

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.378%

Totals Coverage Status
Change from base Build 11667882952: 0.0%
Covered Lines: 3450
Relevant Lines: 4188

💛 - Coveralls

@penelopeysm
Copy link
Member Author

... And these test failures weren't caught earlier because a version of Turing that was compatible with DPPL 0.30 wasn't released earlier.

@torfjelde
Copy link
Member

Do we know which changes have caused the Turing.jl integration to start failing here?

@penelopeysm
Copy link
Member Author

penelopeysm commented Nov 6, 2024

And missed this one too. IIRC, the Turing integration test failures were only DynamicPPL-related, so they should go away now :) (although there will still be Enzyme errors)

@yebai yebai marked this pull request as ready for review November 6, 2024 12:11
@yebai yebai enabled auto-merge November 6, 2024 12:11
@yebai yebai added this pull request to the merge queue Nov 6, 2024
Merged via the queue into master with commit abb2ed4 Nov 6, 2024
14 checks passed
@yebai yebai deleted the py/bijectors-bump branch November 6, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants