Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macOS GHA runner to aarch64 #724

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Update macOS GHA runner to aarch64 #724

merged 1 commit into from
Nov 27, 2024

Conversation

penelopeysm
Copy link
Member

cf. TuringLang/Turing.jl#2395

Also just reworks the CI matrix to be clearer

@penelopeysm penelopeysm marked this pull request as ready for review November 27, 2024 15:33
@coveralls
Copy link

coveralls commented Nov 27, 2024

Pull Request Test Coverage Report for Build 12053991282

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 84.354%

Files with Coverage Reduction New Missed Lines %
src/model.jl 1 93.68%
src/varinfo.jl 6 86.3%
src/simple_varinfo.jl 6 86.6%
src/threadsafe.jl 12 57.76%
Totals Coverage Status
Change from base Build 12053405262: 0.0%
Covered Lines: 3553
Relevant Lines: 4212

💛 - Coveralls

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.35%. Comparing base (5bc980a) to head (5b31ce3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #724   +/-   ##
=======================================
  Coverage   84.35%   84.35%           
=======================================
  Files          35       35           
  Lines        4212     4212           
=======================================
  Hits         3553     3553           
  Misses        659      659           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penelopeysm
Copy link
Member Author

penelopeysm commented Nov 27, 2024

CI failure is unrelated and I've had no luck trying to reproduce it.

Going to merge because this is a boring change which was already discussed on Turing.jl repo

@penelopeysm penelopeysm merged commit 48921d3 into master Nov 27, 2024
11 of 13 checks passed
@penelopeysm penelopeysm deleted the py/macos-aarch64 branch November 27, 2024 18:13
@penelopeysm penelopeysm mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants