Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NOJIRA-123): post adoption comment if js files are renamed to ts #167

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

trapped
Copy link
Member

@trapped trapped commented Sep 29, 2023

In a PR where a single file is being renamed from file.js to file.ts, even though the TS adoption is changing, the comment is being posted because only the old filename of the changed file ends in .js.
Adds a condition for detecting renames.

@trapped trapped requested a review from a team September 29, 2023 09:11
@trapped trapped merged commit 8cf600d into main Sep 29, 2023
5 checks passed
@trapped trapped deleted the fix/NOJIRA-123_req_ts_comment_rename branch September 29, 2023 09:14
@typeform-ops-gha
Copy link

🎉 This PR is included in version 1.27.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants