Md 1172

[protitude]

Describe context / purpose for this PR

Shentity Tweaks

Issue link

#1172

Any other related PRs?

• https://github.com/UCBoulder/oit_dingo/pull/1173
• 2.0.x shentity#1

Link to MultiDev instance

http://md-1172-ucbsub-oit.pantheonsite.io

[Copilot]

Pull request overview

This PR applies “Shentity” related tweaks to the module’s Google Sheets integration and the table search behavior, including additional input handling and a cleanup/removal of an unused plugin.

Changes:

• Add input validation/sanitization to Google Sheets processing, including safer handling of unexpected data.
• Extend Google Sheets fetching/API to optionally accept a full Google Docs URL for Shentity use cases.
• Update table search JS to support multiple .table-search instances with unique search inputs.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/Plugin/GoogleSheetsTopLinks.php	Removes the GoogleSheetsTopLinks plugin implementation.
src/Plugin/GoogleSheetsProcess.php	Adds validation and sanitization when processing fetched sheet data.
src/Plugin/GoogleSheetsFetch.php	Adds optional $shentity mode and sanitization for feed construction.
src/Plugin/GoogleSheetsApi.php	Passes through new $shentity parameter to the fetcher.
js/table_search.js	Refactors to handle multiple searchable tables with unique input IDs.

Comments suppressed due to low confidence (1)

src/Plugin/GoogleSheetsFetch.php:56

• When $shentity is TRUE and $key fails the prefix check, $feed becomes NULL but is still passed to new CvsToArray($feed, ','). This will trigger fopen(NULL, 'r') warnings and can lead to downstream warnings when processing $data. Add an early return / fallback ($this->fetchData = []) when $feed is empty or invalid.

  public function __construct($key, $gid, $shift = 0, $shentity = FALSE) {
    if ($shentity) {
      // Check the url starts with 'https://docs.google.com'.
      $feed = !empty($key) && strpos($key, 'https://docs.google.com') === 0 ? $key : NULL;
    }
    else {
      $key = !empty($key) ? Xss::filter($key) : NULL;
      $gid = $gid >= 0 ? $gid : NULL;
      // See https://gist.github.com/pamelafox/770584
      $feed = "https://docs.google.com/spreadsheets/d/$key/pub?gid=$gid&single=true&output=csv";
    }
    // Arrays we'll use later.
    $newArray = [];
    // Do it.
    $this->cvsSheet = new CvsToArray($feed, ',');
    $data = $this->cvsSheet->getBuiltArray();

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

@protitude I've opened a new pull request, #15, to work on those changes. Once the pull request is ready, I'll request review from you.