Conversation
Add unique ids to table - shortcode no longer render through rich_text
Attempt to randomize id
Merged
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the shentity Drupal module to support newer Google Sheets “full CSV URL” sharing, deprecating the older “key” approach and adjusting how rendered sheet output is stored/displayed.
Changes:
- Add a new
full_keybase field (and deprecatekey) for storing the full Google “output=csv” URL. - Update presave behavior to fetch sheet content using
full_keyand hide legacy form fields. - Adjust rendered table output (randomized table ID / new CSS class) and change GSS shortcode rendering.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/Plugin/PullGoogleSheet.php |
Accepts full Google URL input, passes a new flag to the Sheets API call, and randomizes rendered table IDs/classes. |
src/Entity/Shentity.php |
Deprecates key, introduces required full_key, and relaxes sheet_number requirement. |
shentity.module |
Switches presave to use full_key and hides deprecated fields on the shentity form. |
shentity.deploy.php |
Adds a deploy hook to add/populate full_key for existing entities. |
modules/gss/src/Plugin/Shortcode/GssShortcode.php |
Changes shortcode output from check_markup() to an inline template rendering approach. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updated url check Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Valid digit check Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe context / purpose for this PR
Shentity Tweaks
Issue link
#1172
Any other related PRs?
Link to MultiDev instance
http://md-1172-ucbsub-oit.pantheonsite.io