Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lidar graph #112

Merged
merged 10 commits into from
Jun 1, 2024
Merged

Lidar graph #112

merged 10 commits into from
Jun 1, 2024

Conversation

vrushang1234
Copy link
Contributor

Added graph for lidar on the controls page

ryescholin
ryescholin reviewed Jun 1, 2024
View reviewed changes
Copy link
Member

@ryescholin ryescholin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

pod-operation/src/main.rs Outdated Show resolved Hide resolved
pod-operation/src/state_machine.rs Outdated Show resolved Hide resolved
@ryescholin ryescholin self-requested a review June 1, 2024 06:00
@taesungh taesungh mentioned this pull request Jun 1, 2024
Closed
taesungh
taesungh previously requested changes Jun 1, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
control-station/src/services/PodSocketClient.ts Outdated Show resolved Hide resolved
control-station/src/components/SensorBoxes/Camera.tsx Outdated Show resolved Hide resolved
control-station/src/components/SensorBoxes/Camera.tsx Outdated Show resolved Hide resolved
control-station/package.json Show resolved Hide resolved
taesungh
taesungh reviewed Jun 1, 2024
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
taesungh
taesungh reviewed Jun 1, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the previous comments still haven't been addressed: please actually have a look at the diff of the PR. Additionally, you'll need to address the merge conflicts by rebasing or merging in main.

github-actions[bot]
github-actions bot reviewed Jun 1, 2024
View reviewed changes
control-station/package-lock.json Outdated Show resolved Hide resolved
control-station/package-lock.json Outdated Show resolved Hide resolved
ryescholin
ryescholin approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@ryescholin ryescholin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yippee

@vrushang1234 vrushang1234 merged commit 7fad876 into main Jun 1, 2024
2 checks passed
@taesungh taesungh deleted the lidar-graph branch June 1, 2024 12:28
@taesungh taesungh linked an issue Jun 9, 2024 that may be closed by this pull request
[GUI] Lidar graph on main page #102
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taesungh taesungh taesungh left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@ryescholin ryescholin ryescholin approved these changes

@samderanova samderanova samderanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GUI] Lidar graph on main page
4 participants
@vrushang1234 @samderanova @taesungh @ryescholin