Conversation
|
Could you rebase with the latest |
|
U bet, want me to keep/include PT code in fsm? |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
taesungh
left a comment
There was a problem hiding this comment.
There's a lot of different stuff going on here: could we separate out the portions of the tasks within #18 to reduce the scope of this PR? In particular, it would help to have three separate PRs for #19, #21, and #26 to review smaller chunks. Notably, we'll need a way to periodically emit data from the FSM as part of #19.
|
For clarity: I think i can clean up majority of these issues by adding emit function to run periodically, and moving handler functions, enteractions, statetransition functions into fsm (which will get rid of global state value, keep one functional state value within fsm). (ill add in pt, signallight when done) correct me if I'm wrong @taesungh |
Let's focus on one step at a time: get the fsm in a clean place first. please do not integrate any actual sensor measurements or peripheral control yet, we can handle that in a separate PR. |
|
thats what i meant lol |
|
Ok, most of stuff is updated, having trouble not using GLOBAL_STATE because of the handlers, lemme know if you have any ideas @taesungh |
|
Whatever works best @taesungh |
taesungh
left a comment
There was a problem hiding this comment.
Update: we can live with the global state situation for now and revisit that next. Few other organizational notes and things that would be nice to separate.
|
Could we run |
|
submitted formatted ver, lemme know if there's anything else I can do to fix anything on this rn @taesungh |
samderanova
left a comment
There was a problem hiding this comment.
Looking good, let's revisit the issues here later.
taesungh
left a comment
There was a problem hiding this comment.
Thanks for the continued effort on this. Some areas still we could revisit, particularly the global state variable, transition logic, and client-side handlers.
Hella merge errors, I can take care of a lil later