Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename UU-Fin to Type-With-Cardinality-ℕ #1316

Merged

Conversation

fredrik-bakke
Copy link
Collaborator

No description provided.

@fredrik-bakke
Copy link
Collaborator Author

This is my last univalent combinatorics PR for the time being.

@fredrik-bakke
Copy link
Collaborator Author

fredrik-bakke commented Feb 11, 2025

We could also consider the slightly shorter name Type-With-Cardinality-ℕ.

EDIT: I went for this name.

@fredrik-bakke fredrik-bakke marked this pull request as draft February 11, 2025 15:43
@fredrik-bakke fredrik-bakke changed the title Rename UU-Fin to Type-With-Finite-Cardinality Rename UU-Fin to Type-With-Cardinality-ℕ Feb 11, 2025
@fredrik-bakke fredrik-bakke marked this pull request as ready for review February 11, 2025 15:54
@EgbertRijke
Copy link
Collaborator

This pull request contains some big improvements, so I am ready to merge it.

On the other hand, it also brings to the surface a problem that we will need to address at some point. It is really strange to name a group after the specification of its classifying type. Instead, the group should be named after the symmetries it contains. For example, Type-Of-Squares-Group would be a really strange name for the dihedral group. We create this sort of problems when we write Type-With-Cardinality-N-(Concrete-)Group.

Probably the best solution would be to create a separate file for pointed connected types, have the type of types with cardinality n be a pointed connected type, and introduce the nth symmetric concrete group as the pointed connected type of types with cardinality n.

@EgbertRijke EgbertRijke enabled auto-merge (squash) February 14, 2025 17:27
@EgbertRijke EgbertRijke disabled auto-merge February 14, 2025 17:27
@EgbertRijke EgbertRijke enabled auto-merge (squash) February 14, 2025 17:28
@EgbertRijke EgbertRijke merged commit 08e7ad6 into UniMath:master Feb 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants