Convert all occurrences of static [public|protected] to [public|protected] static #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DennisHeimbigner
added
the
internal: conventions
In accord with this [comment](Unidata#1152 (review)), this PR converts all occurrences of ```` "static public" to "public static" and "static protected" to "protected static" ```` There are a couple of spotLess changes as well. Warning: It turn out there are a lot of occurrences of "static public", so this PR touches a lot of files. The changes were made by two commands: ```` 1. find . -name '*.java' -exec grep '^[\t ]*static[ ][ ]*public' '{}' \; 2. sed -i.bak2 -e 's|^\([\t ]*\)static[ ][ ]*protected|\1protected static|' <file> ```` Command 1 located all .java files containing "static public". Command 2 was applied to the files located by command 1; it converts "static public" to "public static". Similar commands were applied for "static protected". ## PR Checklist <!-- This will become an interactive checklist once the PR is opened --> - [X] Link to any issues that the PR addresses - [X] Add labels - [X] Open as a [draft PR](https://github.blog/2019-02-14-introducing-draft-pull-requests/) until ready for review - [X] Make sure GitHub tests pass - [ ] Mark PR as "Ready for Review"
haileyajohnson
force-pushed
the
modifyorder.dmh
branch
from
6d334cf
to
7523cb4
Compare
haileyajohnson
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
In accord with this comment, this PR converts all occurrences of
There are a couple of spotLess changes as well.
Warning: It turn out there are a lot of occurrences of "static public", so this PR touches a lot of files.
The changes were made by two commands:
Command 1 located all .java files containing "static public". Command 2 was applied to the files located by command 1; it converts "static public" to "public static". Similar commands were applied for "static protected".
PR Checklist