Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all occurrences of static [public|protected] to [public|protected] static #1194

Merged
merged 1 commit into from
Jun 20, 2023

Commits on Jun 20, 2023

  1. ## Description of Changes

    In accord with this [comment](Unidata#1152 (review)), this PR converts all occurrences of
    ````
    "static public" to "public static"
    and
    "static protected" to "protected static"
    ````
    There are a couple of spotLess changes as well.
    
    Warning: It turn out there are a lot of occurrences
    of "static public", so this PR touches a lot of files.
    
    The changes were made by two commands:
    ````
    1. find . -name '*.java' -exec grep '^[\t ]*static[ ][ ]*public' '{}' \;
    2. sed -i.bak2 -e 's|^\([\t ]*\)static[ ][ ]*protected|\1protected static|' <file>
    ````
    Command 1 located all .java files containing "static public".
    Command 2 was applied to the files located by command 1; it converts "static public" to "public static".
    Similar commands were applied for "static protected".
    
    ## PR Checklist
    <!-- This will become an interactive checklist once the PR is opened -->
    - [X] Link to any issues that the PR addresses
    - [X] Add labels
    - [X] Open as a [draft PR](https://github.blog/2019-02-14-introducing-draft-pull-requests/)
           until ready for review
    - [X] Make sure GitHub tests pass
    - [ ] Mark PR as "Ready for Review"
    DennisHeimbigner authored and haileyajohnson committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    7523cb4 View commit details
    Browse the repository at this point in the history