Fix a bug with geotiff writing when yaxis is flipped #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
... I swear, one of these days I'll remember to use spotlessApply before committing... |
tdrwenski
force-pushed
the
fix-lambertconf-geotiff
branch
from
c3a64ce
to
4129657
Compare
|
Just to add a clarifying comment here (and I'll correct the comment in the code in my other PR), I got my sense of "flipped" flipped around. The test data is special because its y-axis goes from negative to positive, which is the condition in which the geotiff writer will flip the data around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Correctly compute yStart when flipping the y-axis. Not doing can result in the bounding box to be in the wrong location if the source coordinates were in kilometers.
PR Checklist
until ready for review