Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug with geotiff writing when yaxis is flipped #1342

Merged
merged 2 commits into from
May 9, 2024
Merged

Fix a bug with geotiff writing when yaxis is flipped #1342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aba8654
Fix a bug with geotiff writing when yaxis is flipped
WeatherGod May 9, 2024
4129657
Style fixes
WeatherGod May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cdm/misc/src/main/java/ucar/nc2/geotiff/GeotiffWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ public void writeGrid(GeoReferencedArray array, boolean greyScale) throws IOExce
Array data = array.getData().reduce();
if (yaxis.getCoordMidpoint(0) < yaxis.getCoordMidpoint(1)) {
data = data.flip(0);
yStart = yaxis.getCoordEdgeLast();
yStart = yaxis.getCoordEdgeLast() * scaler;
}

/*
Expand Down
Binary file added cdm/misc/src/test/data/ucar/nc2/geotiff/categorical.nc
View file
Open in desktop
Binary file not shown.
5 changes: 5 additions & 0 deletions cdm/misc/src/test/java/ucar/nc2/geotiff/TestGeoTiffWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@ public static List<Object[]> getTestParameters() {

result.add(new Object[] {TestDir.cdmUnitTestDir + "ft/coverage/testCFwriter.nc", FeatureType.GRID, "Temperature",
greyscale == 1});

// This file is unique in that it is lambert conformal with yaxis flipped.
result.add(
new Object[] {"src/test/data/ucar/nc2/geotiff/categorical.nc", FeatureType.GRID, "drought", greyscale == 1});

}

return result;
Expand Down