-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Change location of the link xml file so that it can persist beyond an editor shutdown. #2092
base: develop
Are you sure you want to change the base?
Conversation
…and not cleaned when exiting Unity Editor (ISX-2140)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to make part of Library
instead. Thanks for the fix.
Added QA representative for quality check since not covered by automated tests. |
@bitter Suggesting adding a line to https://github.com/Unity-Technologies/InputSystem/blob/develop/Packages/com.unity.inputsystem/CHANGELOG.md according to other patterns for ISXB issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, checked that there's no issues building when upgrading the input system version to this one and whether the actual code stripping step still works (Win 11 player, simply checked for it in the progress bar and compared the build file size)
done - 6a1b455 |
Thank you @Pauliusd01 |
Description
Fixes ISX-2140
Fix location of link xml file. We need a location that is persistent and not cleaned when exiting Unity Editor
Testing status & QA
Tested locally building an Android IL2CPP variation.
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: