Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Change location of the link xml file so that it can persist beyond an editor shutdown. #2092

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

bitter
Copy link
Member

@bitter bitter commented Dec 17, 2024

Description

Fixes ISX-2140
Fix location of link xml file. We need a location that is persistent and not cleaned when exiting Unity Editor

Testing status & QA

Tested locally building an Android IL2CPP variation.

  • Complexity: 0
  • Halo Effect: 0

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

…and not cleaned when exiting Unity Editor (ISX-2140)
@bitter bitter changed the title Change location of the link xml file so that it can persist beond an editor shutdown. FIX: Change location of the link xml file so that it can persist beond an editor shutdown. Dec 17, 2024
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to make part of Library instead. Thanks for the fix.

@ekcoh ekcoh requested a review from Pauliusd01 December 17, 2024 20:07
@ekcoh
Copy link
Collaborator

ekcoh commented Dec 17, 2024

Added QA representative for quality check since not covered by automated tests.

@ekcoh
Copy link
Collaborator

ekcoh commented Dec 17, 2024

@bitter Suggesting adding a line to https://github.com/Unity-Technologies/InputSystem/blob/develop/Packages/com.unity.inputsystem/CHANGELOG.md according to other patterns for ISXB issues.

@ekcoh ekcoh changed the title FIX: Change location of the link xml file so that it can persist beond an editor shutdown. FIX: Change location of the link xml file so that it can persist beyond an editor shutdown. Dec 17, 2024
Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked that there's no issues building when upgrading the input system version to this one and whether the actual code stripping step still works (Win 11 player, simply checked for it in the progress bar and compared the build file size)

@bitter
Copy link
Member Author

bitter commented Dec 18, 2024

@bitter Suggesting adding a line to https://github.com/Unity-Technologies/InputSystem/blob/develop/Packages/com.unity.inputsystem/CHANGELOG.md according to other patterns for ISXB issues.

done - 6a1b455

@bitter
Copy link
Member Author

bitter commented Dec 18, 2024

Thank you @Pauliusd01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants