Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Change location of the link xml file so that it can persist beyond an editor shutdown. #2092

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+7 −3
Open

FIX: Change location of the link xml file so that it can persist beyond an editor shutdown. #2092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfca039
Fix location of link xml file. We need a location that is persistent …
bitter Dec 17, 2024
6a1b455
Added changelog entry
bitter Dec 18, 2024
fe9e966
Merge branch 'develop' into isx-2140-fix-link-xml-location
ekcoh Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Packages/com.unity.inputsystem/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ however, it has to be formatted properly to pass verification tests.
- Fixed Action properties edition in the UI Toolkit version of the Input Actions Asset editor. [ISXB-1277](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1277)

### Changed
- Changed location of the link xml file (code stripping rules), from a temporary directory to the project Library folder (ISX-2140).
- Added back the InputManager to InputSystem project-wide asset migration code with performance improvement (ISX-2086).
- Changed `OnScreenControl` to automaticaly switch, in Single Player with autoswitch enabled, to the target device control scheme when the first component is enabled to prevent bad interactions when it start.
- Changed paremeter `overrideModifiersNeedToBePressedFirst` to obsolete for `ButtonWithOneModifier`, `ButtonWithTwoModifiers`, `OneModifierComposite` and `TwoModifiersComposite` in favour the new `modifiersOrder` parameter which is more explicit.
Expand Down
9 changes: 6 additions & 3 deletions Packages/com.unity.inputsystem/InputSystem/Editor/BuildPipeline/LinkFileGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,12 @@ public string GenerateAdditionalLinkXmlFile(BuildReport report, UnityLinkerBuild

sb.AppendLine("</linker>");

var filePathName = Path.Combine(Application.dataPath, "..", "Temp", "InputSystemLink.xml");
File.WriteAllText(filePathName, sb.ToString());
return filePathName;
var linkXmlDirectory = Path.Combine(Application.dataPath, "..", "Library", "InputSystem");
var linkXmlFile = Path.Combine(linkXmlDirectory, $"{data.target}Link.xml");

Directory.CreateDirectory(linkXmlDirectory);
File.WriteAllText(linkXmlFile, sb.ToString());
return linkXmlFile;
}

static bool IsTypeUsedViaReflectionByInputSystem(Type type)
Expand Down
Loading