Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: late joiners would be displayed as selected [MTTB-4] #899

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Jan 16, 2025

Description

This PR fixes the issue where a previously connected client's party HUD slot would be displayed as selected (green) when a new client would join and assume that slot. The state is now cleared on an ally's disconnected callback.

To validate (min steps):

  • Have one player host
  • Connect a client
  • Have host select (target) client
  • Have client disconnect
  • Reconnect client

Expected: PartyHUD state for client should be unselected

Issue Number(s)

MTTB-4

Contribution checklist

  • [ N/A ] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • [ N/A ] An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez marked this pull request as ready for review January 16, 2025 21:11
@fernando-cortez fernando-cortez requested a review from a team as a code owner January 16, 2025 21:11
@FabianStoll FabianStoll self-requested a review January 17, 2025 15:06
FabianStoll
FabianStoll previously approved these changes Jan 17, 2025
Copy link

@FabianStoll FabianStoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described

@fernando-cortez fernando-cortez merged commit abc9b7d into develop Jan 17, 2025
13 checks passed
@fernando-cortez fernando-cortez deleted the fix/green-names-on-late-joiners branch January 17, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants