Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: late joiners would be displayed as selected [MTTB-4] #899

Merged
merged 6 commits into from
Jan 17, 2025
+37 −30
Merged

fix: late joiners would be displayed as selected [MTTB-4] #899

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f53d0a5
first pass on fix
fernando-cortez Nov 6, 2024
83d234e
Merge branch 'develop' into fix/green-names-on-late-joiners
fernando-cortez Jan 16, 2025
ebc262d
comment cleanup
fernando-cortez Jan 16, 2025
85318a7
changelog addition
fernando-cortez Jan 16, 2025
003c718
Merge branch 'develop' into fix/green-names-on-late-joiners
fernando-cortez Jan 17, 2025
325168b
reformatting
fernando-cortez Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
comment cleanup
@fernando-cortez
fernando-cortez committed Jan 16, 2025
commit ebc262d1ab0eec02e55638628812faa57983a80e
1 change: 0 additions & 1 deletion Assets/Scripts/Gameplay/UI/PartyHUD.cs
View file
Original file line number Diff line number Diff line change
@@ -215,7 +215,6 @@ void OnHeroSelectionChanged(ulong prevTarget, ulong newTarget)
}

// Helper to change name appearance for selected or unselected party members
// also updates m_CurrentTarget
void SetHeroSelectFX(ulong target, bool selected)
{
// check id against all party slots