Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: server exception loop #2652

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

slb1988
Copy link

@slb1988 slb1988 commented Aug 2, 2023

When NetworkManager.SceneManager.SynchronizeNetworkObjects got exception, there will always got exception in AddClient for add ConnectedClients dictionary multi times. Client and Server all get stuck.

Changelog

  • Added: The package whose Changelog should be added to should be in the header. Delete the changelog section entirely if it's not needed.
  • Fixed: If you update multiple packages, create a new section with a new header for the other package.
  • Removed/Deprecated/Changed: Each bullet should be prefixed with Added, Fixed, Removed, Deprecated, or Changed to indicate where the entry should go.

Testing and Documentation

  • No tests have been added.
  • Includes unit tests.
  • Includes integration tests.
  • No documentation changes or additions were necessary.
  • Includes documentation for previously-undocumented public API entry points.
  • Includes edits to existing public API documentation.

When NetworkManager.SceneManager.SynchronizeNetworkObjects got exception, there will always got exception in AddClient for add ConnectedClients dictionary multi times. Client and Server all get stuck.
@slb1988 slb1988 requested a review from a team as a code owner August 2, 2023 23:14
@unity-cla-assistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@NoelStephensUnity
Copy link
Collaborator

Interesting... I think I see what you are talking about with that change.
Will look at it closer tomorrow....but thank you very much for the PR submission and contributing to help make NGO better!
👍 💯

slb1988 added 2 commits August 4, 2023 12:16
Duplicate GlobalObjectIdHash come out always, globalObjectId got null in some phase like PrefabImporterEditor::OnDestroy, another problem is GlobalObjectIdHash changed but prefab don't.
fix duplicate GlobalObjectIdHash & not save problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants