fix: Errors with NetworkVariable<float> and others in inspector #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes NetworkVariables with NonSerializedAttribute showing in editor when they should not.
| @@ -496,6 +499,13 @@ private bool ImportReferences(ModuleDefinition moduleDefinition) | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| bool isEditor = assemblyDefines.Contains("UNITY_EDITOR"); | |||
There was a problem hiding this comment.
Ahh... I was wondering when you were going to use the assenblyDefines...and then it all made sense how you are fixing the exception and the visibility issue together.
🥇
NoelStephensUnity
approved these changes
Sep 26, 2023
# Conflicts: # com.unity.netcode.gameobjects/CHANGELOG.md # com.unity.netcode.gameobjects/Editor/CodeGen/NetworkBehaviourILPP.cs
NoelStephensUnity
pushed a commit
that referenced
this pull request
Oct 5, 2023
Also fixes NetworkVariables with NonSerializedAttribute showing in editor when they should not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes NetworkVariables with NonSerializedAttribute showing in editor when they should not.
fixes #2709
Changelog
Testing and Documentation