Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: distribute parented children distributing with root parent #3203

Draft
wants to merge 4 commits into
base: develop-2.0.0
Choose a base branch
from

Conversation

NoelStephensUnity
Copy link
Collaborator

This fixes an issue with distributing parented children that have the distributable and/or transferrable permissions set and have the same owner as the root parent, that has the distributable permission set, were not being distributed to the same client upon the owning client disconnecting when using a distributed authority network topology.

Changelog

  • Fixed: Issue with distributing parented children that have the distributable and/or transferrable permissions set and have the same owner as the root parent, that has the distributable permission set, were not being distributed to the same client upon the owning client disconnecting when using a distributed authority network topology.

Testing and Documentation

  • Includes integration test (wip).
  • Public documentation for rules to object distribution with parented NetworkObjects.

This is the initial fix for distributing parented children that have the distributable and/or transferrable permissions set and have the same owner as the root parent, that has the distributable permission set, upon the owning client disconnecting when using a distributed authority network topology.
Adding initial change log entry.
adding PR number to entry
Handle check for parent earlier.
Add additional comment details.
@michalChrobot michalChrobot added the stat:awaiting triage Status - Awaiting triage from the Netcode team. label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat:awaiting triage Status - Awaiting triage from the Netcode team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants