Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nested NetworkTransforms with different authority settings #3209

Draft
wants to merge 4 commits into
base: develop-2.0.0
Choose a base branch
from

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Jan 17, 2025

This PR focuses on fixing a regression bug introduced when the ordered synchronization of nested NetworkTransform components was added to v2.x. The addition did not take into consideration that there could be mixed authority modes within the nested NetworkTransform components which requires additional checks to exclude the nested NetworkTransform components from this process as well as excluding them from synchronized state upates.

fix: #3205

Changelog

  • Fixed: Issue where a NetworkObject with nested NetworkTransform components of varying authority modes was not being taken into consideration and would break both the initial NetworkTransform synchronization and fail to properly handle synchronized state updates of the nested NetworkTransform components.

Testing and Documentation

  • Includes integration tests (wip).
  • No documentation changes or additions were necessary.

First pass fixes for mixed authority mode nested networktransforms.
adding additional comments
Remove commented code.
Add additional comments for clarity.
adding changelog entry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant