Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more accurate local time sync with server time (up-port) #3212

Open
wants to merge 5 commits into
base: develop-2.0.0
Choose a base branch
from

Conversation

NoelStephensUnity
Copy link
Collaborator

User Contribution (@BenHamrick) (#3028)
Up-port of #3206

This PR changes the NetworkTimeSystem.Sync method to use half RTT to calculate the desired local time offset as opposed to the full RTT.

Changelog

  • Changed: NetworkTimeSystem.Sync method to use half RTT to calculate the desired local time offset as opposed to the full RTT.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

BenHamrick and others added 4 commits January 19, 2025 10:48
Adjusting ClientNetworkTimeSystemTests to account for half RTT adjustment applied in this PR.
Adding a comment about the change
Adding changelog entry
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review January 19, 2025 16:53
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner January 19, 2025 16:53
removing white space after comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants