Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: networktransform double lerp (MTTB-539) #3337

Draft
wants to merge 25 commits into
base: develop-2.0.0
Choose a base branch
from

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Mar 5, 2025

This PR fixes the issue with double lerping by providing two options:

  • The ability to adjust the MaximumInterpolationTime for each respective interpolator type.
  • A second interpolation option that uses smooth dampening as opposed to double lerping.

MTTB-539
MTT-11338 -- Fixing disabled tests

fix: #3112
close: #3112

Changelog

  • Fixed: WIP

Testing and Documentation

  • Includes integration test updates (wip).
  • Includes updates and additions to public documentation (wip)

Some additional updates... still having a hard time getting a single lerp pass without some form of slight jitter.
This includes a temporary 2nd pass lerp that still allows for the buffered item value to be completely reached.
Simplifying the new direction and getting all tests to pass.
(still needs a smoother transition between buffered items when not finished interpolating from a previous one)
 adding some needed comments
Still work in progress. Needs some clean up, but it is looking promising.
The base.OnUpdate is not needed here.
WIP:
Smooth dampening seems to be working better than any interpolation approach. Still have a minor timing issue, but I believe can be solved....much closer to a more resilient "interpolator".
Time systems related updates
NetworkTransform and BufferedLinearInterpolator related updates.
Minor fixes for recent changes.
some clean up from wip.
Fixing PVP issues.
Adding XML API documentation to some new NetworkTransform properties.
More PVP fun
More and more PVP fun.
Missed two PVP issues.
Adding Lerp and SmoothDampening to TestFixutres.
Putting some things back and realized I should adhere to the original buffered linear interpolator logic/pattern when using Lerp for interpolation to assure there is no impact on users with this update.
Made an adjustment to the InterpolatorTests.TestUpdatingInterpolatorWithNoData,.
Also fixed the two tests that were disabled due to no extrapolation.
Minor fix for an issue when dividing up the smooth damp and lerp buffer consumption.
Made some more adjustments as well as added a predicted smooth dampened value to help with smoothing and to get closer to the target value on the non-authority side.
Updated the Quaternion's Approximation to use the dot product instead.
Fixing a bug with one of the tests  (evidently was not caught  using the previous BLI)
Some fixes for the one test that was failing and more TestFixture additions.
Not sure why these two SetState lerp interpolation tests are having issues as it passes in the editor but fails at runtime... most likely a timing related issue.
Clearing out the 2nd rate of change.
Adding delay for the end of the last test in NetworkTransformGeneral.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant