chore: Update the port of the codec tests #3341
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchroer
reviewed
Mar 5, 2025
| @@ -30,7 +30,7 @@ internal class DistributedAuthorityCodecTests : NetcodeIntegrationTest | |||
| private NetworkManager Client => m_ClientNetworkManagers[0]; | |||
|
|
|||
| private string m_TransportHost = Environment.GetEnvironmentVariable("NGO_HOST") ?? "127.0.0.1"; | |||
| private const int k_TransportPort = 7777; | |||
| private const int k_TransportPort = 7788; | |||
There was a problem hiding this comment.
Can we move to a environment variable configurable port? Along the lines of Environment.GetEnvironmentVariable("NGO_PORT")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the port for the
DistributedAuthorityCodecTestsfrom7777to7788as7777is the same port used by the Unity Transport tests and this is causing issues.MTT-11549
Changelog