Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calibration (backport #1017) #1023

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix calibration (backport #1017) #1023

merged 1 commit into from
Jun 17, 2024

Commits on Jun 17, 2024

  1. Fix calibration (#1017)

    * Make calibration tests parametrizable
    
    * Add two more real-world configurations to tests
    
    Note: the second one fails with our current implementation
    
    * Fix calibration correction
    
    There was an error from using std::atan instead of std::atan2.
    In most cases that seemed to work fine, but with certain calibrations the
    calculated angle could end up in another quadrant, so atan was returning
    the wrong angle.
    
    We renamed a lot of variables and changed some of the docstrings in order
    to hopefully make things more understandable in the future.
    
    * Add robot model to calibration tests
    
    * Add documentation to calibration algorithm
    
    * Add a comment on test suite parametrization
    
    (cherry picked from commit 557b57e)
    
    # Conflicts:
    #	ur_calibration/doc/index.rst
    fmauch authored and mergify[bot] committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    b688493 View commit details
    Browse the repository at this point in the history