-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix component lifecycle #1098
Fix component lifecycle #1098
Conversation
I don't understand why I closed this one month ago. We should merge this and create a separate issue for creating lifecycle tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and it solves the addressed issue.
@Mergifyio backport humble @Mergifyio backport iron |
✅ Backports have been created
|
* Correctly reset async_thread_shutdown when starting the async thread * Do not use a global log handler object --------- (cherry picked from commit 141a17a)
@Mergifyio backport iron |
✅ Backports have been created
|
* Correctly reset async_thread_shutdown when starting the async thread * Do not use a global log handler object --------- (cherry picked from commit 141a17a)
* Correctly reset async_thread_shutdown when starting the async thread * Do not use a global log handler object
* Correctly reset async_thread_shutdown when starting the async thread * Do not use a global log handler object
This is closing #1097
As mentioned in the issue I would like to combine this issue with tests for lifecycle management.