Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix component lifecycle #1098

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Sep 11, 2024

This is closing #1097

As mentioned in the issue I would like to combine this issue with tests for lifecycle management.

@fmauch fmauch linked an issue Sep 11, 2024 that may be closed by this pull request
1 task
@fmauch fmauch closed this Sep 20, 2024
@fmauch fmauch deleted the fix_component_lifecycle branch September 20, 2024 11:28
@fmauch fmauch restored the fix_component_lifecycle branch October 16, 2024 18:11
@fmauch
Copy link
Collaborator Author

fmauch commented Oct 16, 2024

I don't understand why I closed this one month ago. We should merge this and create a separate issue for creating lifecycle tests.

@fmauch fmauch reopened this Oct 16, 2024
@fmauch fmauch marked this pull request as ready for review October 16, 2024 18:12
@fmauch fmauch requested a review from VinDp October 16, 2024 18:12
Copy link
Collaborator

@VinDp VinDp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and it solves the addressed issue.

@VinDp VinDp merged commit 141a17a into UniversalRobots:main Oct 21, 2024
10 of 12 checks passed
@fmauch fmauch deleted the fix_component_lifecycle branch October 26, 2024 11:41
@fmauch
Copy link
Collaborator Author

fmauch commented Oct 26, 2024

@Mergifyio backport humble

@Mergifyio backport iron

Copy link

mergify bot commented Oct 26, 2024

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 26, 2024
* Correctly reset async_thread_shutdown when starting the async thread

* Do not use a global log handler object

---------

(cherry picked from commit 141a17a)
@fmauch
Copy link
Collaborator Author

fmauch commented Oct 26, 2024

@Mergifyio backport iron

Copy link

mergify bot commented Oct 26, 2024

backport iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 26, 2024
* Correctly reset async_thread_shutdown when starting the async thread

* Do not use a global log handler object

---------

(cherry picked from commit 141a17a)
fmauch pushed a commit that referenced this pull request Oct 26, 2024
* Correctly reset async_thread_shutdown when starting the async thread

* Do not use a global log handler object
fmauch pushed a commit that referenced this pull request Oct 26, 2024
* Correctly reset async_thread_shutdown when starting the async thread

* Do not use a global log handler object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure During Hardware Component Reconfiguration
2 participants