Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added nasty conditional compilation for compiling scaled JTC on humble #682

Closed

Conversation

firesurfer
Copy link
Contributor

@firesurfer firesurfer commented May 24, 2023

This is definitely not a nice solution but it is a solution which allows to compile the current main branch on humble.

Different solutions that I tried were:

  1. Pass in ROS_DISTRO environment varible as define -> Preprocessor cant do string compares
  2. if constexpr -> Both code paths have to be valid
    -> With SFINAE one could hack this together...

A different solution could be to ask the JTC package maintainers to include the ament_generate_version_header statement. This will generate a header file with the version numbers defined in the package.xml which one could check directly.

Other than that..perhaps something type erasure like where the compiler can't check the method signature anymore :D

@firesurfer
Copy link
Contributor Author

@firesurfer
Copy link
Contributor Author

@fmauch Are you in general interested in such a solution? Implementing something like this would allow building main against humble I think

@fmauch
Copy link
Collaborator

fmauch commented Aug 2, 2023

As written in #674 it is not intended to build the main branch on humble, at all. The main branch is for the most recent changes that are meant to run with rolling. We try to port back as much as possible to humble and iron. If there is something missing in your opinion, please open a separate issue about this.

@fmauch fmauch closed this Aug 2, 2023
@firesurfer
Copy link
Contributor Author

@fmauch Just to comment on this (I do not want to open an additional issue given that there is nothing missing)

I used the main branch in combination with humble for quite some time now and the scaled JTC was the only thing that was causing issues there. I guess you are right, if there are more breaking changes regarding ros2(control) in the future this might be unfeasible to maintain but for now I don't see any reason why one wouldn't want to build the main branch on humble because it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants