Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch out for Iron #753

Merged

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Jul 21, 2023

Since #739 effectively is a break in the user's API we should not forward the iron branch to this change. Hence, we need to branch out and add a mergify rule to make our life easier.

I left the iron workflows running in main PRs on purpose, as in fact iron and rolling are currently still fully compatible.

@fmauch fmauch marked this pull request as ready for review July 21, 2023 12:14
@fmauch
Copy link
Collaborator Author

fmauch commented Aug 28, 2023

@RobertWilbrandt It would be nice if you could have a look at this.

Copy link
Collaborator

@RobertWilbrandt RobertWilbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, looks good to me. I don't agree with the reasoning on the CI workflows (we test rolling anyway and this just seems like a weird inconsistency without any gain), but this PR doesn't really affect that.

@RobertWilbrandt RobertWilbrandt merged commit 2a6b987 into UniversalRobots:main Aug 28, 2023
12 checks passed
@fmauch fmauch deleted the prepare_iron_branch_out branch August 28, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants