Add servo node config to disable advertising /get_planning_scene #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @mrjogo that change seems reasonable. I'll check it and come back to this. |
|
I just tested this and it seems to be fine. If you don't mind, I would include this commit into #998 for jazzy/rolling. This PR here would then be targeting iron and humble only. |
|
Sounds good. Let me know if you need me to do anything for that. |
fmauch
force-pushed
the
fix-servo-planning-config
branch
from
5c98fdd
to
21ed19d
Compare
fmauch
approved these changes
Jun 11, 2024
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
(cherry picked from commit 1baca12)
fmauch
pushed a commit
that referenced
this pull request
Jun 12, 2024
… (#1018) (cherry picked from commit 1baca12) Co-authored-by: Ruddick Lawrence <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables the servo node from advertising
/get_planning_scene, which in the default launchfile, conflicts withmove_group's/get_planning_scene. See moveit/moveit2#2731 for discussion.Tested on a Humble branch.