-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add servo node config to disable advertising /get_planning_scene #990
Conversation
Thank you @mrjogo that change seems reasonable. I'll check it and come back to this. |
I just tested this and it seems to be fine. If you don't mind, I would include this commit into #998 for jazzy/rolling. This PR here would then be targeting iron and humble only. |
Sounds good. Let me know if you need me to do anything for that. |
5c98fdd
to
21ed19d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against iron and works fine.
@Mergifyio backport humble |
✅ Backports have been created
|
(cherry picked from commit 1baca12)
… (#1018) (cherry picked from commit 1baca12) Co-authored-by: Ruddick Lawrence <[email protected]>
Disables the servo node from advertising
/get_planning_scene
, which in the default launchfile, conflicts withmove_group
's/get_planning_scene
. See moveit/moveit2#2731 for discussion.Tested on a Humble branch.