-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make moveit_config compatible to moveit_configs_builder #998
Merged
Commits on Jun 3, 2024
-
Make the config moveit_configs_builder compatible
- Make sure it can be used in conjunction with the configs builder - Still use a parametrized srdf - Re-use the description from the robot state publisher
Configuration menu - View commit details
-
Copy full SHA for 09318d1 - Browse repository at this point
Copy the full SHA 09318d1View commit details -
Wait for robot_description in moveit startup
Since we built our moveit config around receiving the description via topic, we also add a script that waits for the robot description to be published. This helps when components support subscribing to the description, but crash if it is not present.
Configuration menu - View commit details
-
Copy full SHA for f7fd5e0 - Browse repository at this point
Copy the full SHA f7fd5e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfcd962 - Browse repository at this point
Copy the full SHA cfcd962View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18472cc - Browse repository at this point
Copy the full SHA 18472ccView commit details -
Apply suggestions from code review
Co-authored-by: Vincenzo Di Pentima <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 17dfb44 - Browse repository at this point
Copy the full SHA 17dfb44View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac6747e - Browse repository at this point
Copy the full SHA ac6747eView commit details
Commits on Jun 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for da7ae54 - Browse repository at this point
Copy the full SHA da7ae54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06d8df3 - Browse repository at this point
Copy the full SHA 06d8df3View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc35221 - Browse repository at this point
Copy the full SHA fc35221View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.