-
-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update release plans icon #8894
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
@@ -6,7 +6,7 @@ import LanguageIcon from '@mui/icons-material/Language'; | |||
import PowerSettingsNewIcon from '@mui/icons-material/PowerSettingsNew'; | |||
import CodeIcon from '@mui/icons-material/Code'; | |||
import { ReactComponent as RolloutIcon } from 'assets/icons/rollout.svg'; | |||
import FormatListNumberedIcon from '@mui/icons-material/FormatListNumbered'; | |||
import FactCheckOutlinedIcon from '@mui/icons-material/FactCheckOutlined'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we prefer the original name here or assigning as the name of what it's being used as?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the original name, for consistency. It's also easier to copy from MUI's instructions: https://mui.com/material-ui/material-icons/?theme=Outlined&query=list&selected=FactCheckOutlined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
https://linear.app/unleash/issue/2-3042/update-release-plans-feature-icon
Updates the icon for the release plans feature.