Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update release plans icon #8894

Merged
merged 1 commit into from
Dec 2, 2024
Merged

chore: update release plans icon #8894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/component/layout/MainLayout/NavigationSidebar/IconRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import BillingIcon from '@mui/icons-material/CreditCardOutlined';
import EventLogIcon from '@mui/icons-material/EventNoteOutlined';
import GitHubIcon from '@mui/icons-material/GitHub';
import LibraryBooksIcon from '@mui/icons-material/LibraryBooks';
import LaunchIcon from '@mui/icons-material/Launch';
import FactCheckOutlinedIcon from '@mui/icons-material/FactCheckOutlined';
import PersonalDashboardIcon from '@mui/icons-material/DashboardOutlined';
import type { FC } from 'react';

Expand Down Expand Up @@ -58,7 +58,7 @@ const icons: Record<string, typeof SvgIcon> = {
'/admin/cors': CorsIcon,
'/admin/billing': BillingIcon,
'/history': EventLogIcon,
'/release-management': LaunchIcon,
'/release-management': FactCheckOutlinedIcon,
'/personal': PersonalDashboardIcon,
GitHub: GitHubIcon,
Documentation: LibraryBooksIcon,
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/component/releases/ReleasePlanTemplate/TemplateFormDescription.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import ReleaseTemplateIcon from '@mui/icons-material/DashboardOutlined';
import FactCheckOutlinedIcon from '@mui/icons-material/FactCheckOutlined';
import { ReactComponent as MilestoneIcon } from 'assets/icons/milestone.svg';
import { styled } from '@mui/material';

Expand Down Expand Up @@ -43,7 +43,7 @@ export const TemplateFormDescription = () => {
return (
<StyledDescription>
<StyledDescriptionHeader>
<ReleaseTemplateIcon />
<FactCheckOutlinedIcon />
Release templates
</StyledDescriptionHeader>
<p>
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/utils/strategyNames.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import LanguageIcon from '@mui/icons-material/Language';
import PowerSettingsNewIcon from '@mui/icons-material/PowerSettingsNew';
import CodeIcon from '@mui/icons-material/Code';
import { ReactComponent as RolloutIcon } from 'assets/icons/rollout.svg';
import FormatListNumberedIcon from '@mui/icons-material/FormatListNumbered';
import FactCheckOutlinedIcon from '@mui/icons-material/FactCheckOutlined';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we prefer the original name here or assigning as the name of what it's being used as?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original name, for consistency. It's also easier to copy from MUI's instructions: https://mui.com/material-ui/material-icons/?theme=Outlined&query=list&selected=FactCheckOutlined


export const formatStrategyName = (strategyName: string): string => {
return formattedStrategyNames[strategyName] ?? strategyName;
Expand All @@ -33,7 +33,7 @@ export const getFeatureStrategyIcon = (strategyName?: string) => {
case 'applicationHostname':
return LocationOnIcon;
case 'releasePlanTemplate':
return FormatListNumberedIcon;
return FactCheckOutlinedIcon;
default:
return CodeIcon;
}
Expand Down
Loading