chore: pnpmを使う #2511
Merged
chore: pnpmを使う #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
requested review from
Hiroshiba
and removed request for
a team
sevenc-nanashi
commented
Jan 28, 2025
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
|
macはビルドが（おそらく運悪く）落ちてるけど、ビルド済みパッケージはアップロードされてそう！ |
|
のチェック項目を全部試した感じ、全く問題なさそうでした！！！！！ |
Hiroshiba
reviewed
Jan 28, 2025
Comment on lines
+161
to
+163
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@v4 | ||
|
|
There was a problem hiding this comment.
（このプルリクエストに関係ないですが）
あれ、この辺り.github/actions/setup-environment/action.yml使えば不要になる･･･？
なんで共通化してないんだろう。絶対理由があるはずだけど覚えてない。。
There was a problem hiding this comment.
📝 おそらく、共通化したのがテストを速くするための目的で、ビルドも共通化することが目的ではなかったため
Hiroshiba
reviewed
Jan 29, 2025
Hiroshiba
reviewed
Jan 29, 2025
Hiroshiba
reviewed
Jan 29, 2025
Hiroshiba
approved these changes
Jan 29, 2025
| @@ -33,7 +32,8 @@ | |||
| "electron:serve": "cross-env VITE_TARGET=electron vite", | |||
| "browser:serve": "cross-env VITE_TARGET=browser vite", | |||
| "browser:build": "cross-env VITE_TARGET=browser vite build", | |||
| "postinstall": "npm run postinstall:packages && npm run postinstall:download-scripts", | |||
| "preinstall": "npx -y only-allow pnpm", | |||
There was a problem hiding this comment.
📝 これにより間違えてnpm iしてしまった時にエラーが出る
README.md
Outdated
Comment on lines
50
to
51
| # 初回のみ | ||
| npm i -g pnpm |
There was a problem hiding this comment.
これは上のドキュメントと統合したらちょっと読みやすくなるかも？
ちょっとこっちで勝手にコミットします！
…o pr/sevenc-nanashi/2511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
pnpmをつかうようにします。
関連 Issue
スクリーンショット・動画など
（なし）
その他
（なし）