-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pnpmを使う #2511
Merged
Merged
chore: pnpmを使う #2511
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d78f572
Change: pnpmを使う
sevenc-nanashi 6e96990
Fix: CIがpnpmを使う用にする
sevenc-nanashi 836b170
Change: npxを消してみる
sevenc-nanashi 5be1bd5
Change: action-setupを使う
sevenc-nanashi 2b28dc2
Merge branch 'main' into migrate/pnpm
sevenc-nanashi 16fd212
Fix: 細かい所を修正
sevenc-nanashi 1dc35f4
Update: READMEとかを更新
sevenc-nanashi 1f4c41a
Revert: lint周りを戻す
sevenc-nanashi fbf831a
Delete: engines.pnpmを消す
sevenc-nanashi 3d21888
Fix: pnpmを先にインストールする
sevenc-nanashi 4263004
Add: only-allowを足す
sevenc-nanashi 055ac88
Fix: npx -yをする
sevenc-nanashi 0accf18
Update CONTRIBUTING.md
Hiroshiba f94f9fa
少しだけフォーマットを変更
Hiroshiba 94cd6c0
Merge branch 'migrate/pnpm' of github.com:sevenc-nanashi/voicevox int…
Hiroshiba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
engine-strict=true | ||
save-exact=true | ||
@jsr:registry=https://npm.jsr.io | ||
manage-package-manager-versions=true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -78,6 +78,7 @@ VOICEVOXには、下記のような貢献の仕方があります。 | |
### 2. 開発環境の構築 | ||
|
||
- 必須ツール | ||
|
||
- [Node.js](https://nodejs.org/en/download/releases/)\ | ||
[こちら](https://github.com/VOICEVOX/voicevox/blob/main/.node-version)に記載されているバージョンのインストーラを入手し、インストールします。 | ||
|
||
|
@@ -119,8 +120,13 @@ git clone [email protected]:(個人のGitHubアカウント名)/voicevox.git | |
### 5. 必要なプログラムをダウンロードする | ||
|
||
- 手順4で手に入れたフォルダを開いて、コマンドプロンプトを開きます。 | ||
- 環境を準備するコマンド `npm ci` | ||
を実行してください。自動的にダウンロードされます。 | ||
- 環境を準備する以下のコマンドを実行してください。自動的にダウンロードされます。 | ||
|
||
```bash | ||
npm install -g pnpm | ||
pnpm i | ||
``` | ||
|
||
- ツールの組み合わせや実装に関する警告が表示されますが、開発環境を作るうえでは無視して差し支えありません。 | ||
|
||
### 6. エンジンを指定する | ||
|
@@ -150,7 +156,7 @@ VITE_DEFAULT_ENGINE_INFOS=`[ | |
|
||
### 7. 始動してみる | ||
|
||
- `npm run electron:serve`を実行します。 | ||
- `pnpm run electron:serve`を実行します。 | ||
- 設定が正しければ、開発環境が起動するはずです。 | ||
|
||
## プロジェクトへの貢献手順 | ||
|
@@ -222,46 +228,46 @@ VITE_DEFAULT_ENGINE_INFOS=`[ | |
- 記述コードがコーディングルールに沿っていることを確認します。(特に今回の作業によって警告やエラーが増えていないかどうかに注目してください) | ||
|
||
```bash | ||
npm run lint | ||
npm run fmt | ||
pnpm run lint | ||
pnpm run fmt | ||
``` | ||
|
||
- TypeScriptの型チェックを行います。 | ||
|
||
```bash | ||
npm run typecheck | ||
pnpm run typecheck | ||
``` | ||
|
||
- Markdownの記述が正しいことを確認します。 | ||
|
||
```bash | ||
npm run markdownlint ./*/*.md | ||
pnpm run markdownlint ./*/*.md | ||
``` | ||
|
||
- 命名に使っている英語が誤っていないことを確認します。 | ||
|
||
```bash | ||
npm run typos | ||
pnpm run typos | ||
``` | ||
|
||
- 個人環境でVOICEVOXを実行し、提出前に、一通り動くことを確認します。 | ||
|
||
```bash | ||
npm run electron:serve | ||
pnpm run electron:serve | ||
``` | ||
|
||
- 使用するライブラリのライセンスに使用出来ないものが使われていないことを確認します。 | ||
|
||
```bash | ||
npm run license:generate -- -o voicevox_licenses.json | ||
pnpm run license:generate -- -o voicevox_licenses.json | ||
``` | ||
|
||
- e2eテストの内容を確認します。 | ||
|
||
```bash | ||
npm run test:unit | ||
npm run test:browser-e2e | ||
npm run test:electron-e2e | ||
pnpm run test:unit | ||
pnpm run test:browser-e2e | ||
pnpm run test:electron-e2e | ||
``` | ||
|
||
- e2eテストは実際には自分が提出する範囲外の指摘をしたり、完全に警告が消えないことがあります。 | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(このプルリクエストに関係ないですが)
あれ、この辺り
.github/actions/setup-environment/action.yml
使えば不要になる・・・?なんで共通化してないんだろう。絶対理由があるはずだけど覚えてない。。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 おそらく、共通化したのがテストを速くするための目的で、ビルドも共通化することが目的ではなかったため