[TF] Move replay definitions from Base Source VPCs to Mod VPCs #1113
+141
−110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating a TF2 mod with a copied and pasted client_ and server_ VPC file (which is the usual Source SDK workflow for mods prior to the TF2 SDK release), errors related to REPLAY_ENABLED are seen upon compilation. This is due to an $Include file in both client_base.vpc and server_base.vpc that is only allowed to be used in projects with the conditional $TF. Although this works for TF2, this doesn't work when trying to build other derived mods with this source code if you're using a copy-pasted VPC file. In addition, source_replay.vpc recommends that the file be placed in mod VPC files.
This PR aims to dismantle the source_replay implementation from the base source VPCs (client_base and server_base) into replay specific VPCs (server_replay_base.vpc and client_replay_base.vpc) that are included in the mod VPC (server_tf and client_tf). One respective file included into each TF VPC enables the REPLAY_ENABLED conditional. While this doesn't enable replay functionality for all mods (also according to source_replay.vpc), this an effective solution to fix the above listed issue.