Implement wrappers around the Architecture ID types#5431
Closed
rbran wants to merge 2 commits intoVector35:devfrom
Closed
Implement wrappers around the Architecture ID types#5431rbran wants to merge 2 commits intoVector35:devfrom
rbran wants to merge 2 commits intoVector35:devfrom
Conversation
emesare
reviewed
Sep 18, 2024
| self.arch | ||
| .register_by_name(xreg.to_string().to_lowercase()) | ||
| .map(|reg| reg.id() as i64) | ||
| .map(|reg| reg.id().0 as i64) |
Contributor
Author
There was a problem hiding this comment.
Maybe, but not using Into. Maybe something like reg.id().into_inner() or reg.raw_id().
Contributor
Author
There was a problem hiding this comment.
The as i64 can be replaced with .into(). But the .0 can only be replaced with a appropriated named function.
Member
|
This is available with ace9ba8 However I didn't add that field helper, I find that a little useless, maybe I misunderstand the purpose but it seems unnecessary. Please correct me if I'm wrong. |
Contributor
Author
|
Do you mean the |
Closed
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using naked ids (u32) for types like: Register, Flag, Intrinsic, etc. This PR replaces those types with wrappers like: RegisterId, FlagId, IntrinsicId, etc.
The objective is to provide a more clear API for the user, once the type RegisterId can't be confused with any other u32.
This pattern also allow the creation of the
ArchitectureExt::get_fieldthat can receive any kind of id an return the corresponding type, eg: