fix: fix progress cell create problem in vtable-export #1787

VisActor · May 24, 2024 · ee26f46 · ee26f46
1 parent e772cfb
commit ee26f46
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/common/changes/@visactor/vtable/fix-progress-cell-export_2024-05-24-09-45.json b/common/changes/@visactor/vtable/fix-progress-cell-export_2024-05-24-09-45.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@visactor/vtable",
+      "comment": "fix: fix progress cell create problem in vtable-export #1787",
+      "type": "none"
+    }
+  ],
+  "packageName": "@visactor/vtable"
+}
diff --git a/packages/vtable-export/src/excel/index.ts b/packages/vtable-export/src/excel/index.ts
@@ -175,14 +175,15 @@ function exportCellImg(col: number, row: number, tableInstance: IVTable) {
   let needRemove = false;
   if (cellGroup.role === 'empty') {
     cellGroup = updateCell(col, row, tableInstance as any, true);
+    cellGroup.setStage(tableInstance.scenegraph.stage);
     needRemove = true;
   }
   const oldStroke = cellGroup.attribute.stroke;
   cellGroup.attribute.stroke = false;
   const canvas = graphicUtil.drawGraphicToCanvas(cellGroup as any, tableInstance.scenegraph.stage) as HTMLCanvasElement;
   cellGroup.attribute.stroke = oldStroke;
   if (needRemove) {
-    cellGroup.parent.removeChild(cellGroup);
+    cellGroup.parent?.removeChild(cellGroup);
   }
   return canvas.toDataURL();
 }
diff --git a/packages/vtable/src/scenegraph/graphic/group.ts b/packages/vtable/src/scenegraph/graphic/group.ts
@@ -377,10 +377,7 @@ export class Group extends VRenderGroup {
 }
 
 function after(group: Group, selfChange: boolean) {
-  if (!group.stage.dirtyBounds) {
-    return;
-  }
-  if (!(group.stage && group.stage.renderCount)) {
+  if (!group.stage || !group.stage.dirtyBounds || !group.stage.renderCount) {
     return;
   }
   // group的子元素导致的bounds更新不用做dirtyBounds