[1.20.4] Some Immersive Portals Fixes #256
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port to 1.20.4 of #246 with the not-really-working rendering fixes not included.
This PR fixes a few issues with Immersive Portals while still leaving some behind:
Issues that still remain:
/tpcommand also can't rotate the player, I don't consider this to be a showstopper. Will likely open an issue for this at some point.What makes this PR so hack-y:
From testing, this does not cause any issues in an environment without ImmersivePortals.
To test this PR, in the
build.gradlefor the modloader, flip themodCompileOnlyfor ImmersivePortals tomodApi, then add the following lines:If wanted, I can include some or all of these changes in the PR, however they aren't at the moment.