[1.21.4] Immersive Portals Fixes #392
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two major "show-stopping" bugs with Immersive Portals, making it work far better in Vivecraft than the "doesn't really" it does right now. This fixes two bugs:
A few issues do remain unpatched, however:
/tpcommand also can't rotate the player, I don't consider this to be a showstopper. Will likely open an issue for this at some point.As this is a port of #256, this does use a mixin into Immersive Portals itself. That said, the area of code mixed into appears to be very stable between Minecraft versions (exists identically in both Immersive Portals for 1.18.2 and for 1.21.1), though long-term, working with the dev team to integrate this properly would be ideal.
This PR can be tested simply by running the 1.21.1 version of this PR. In other words, clone the repository,
git checkout Multiloader-1.21-immersive-portals-fixing(NOTMultiloader-1.21.4-immersive-portals-fixing, as there is no Immersive Portals for 1.21.4), then run via Fabric as usual.Supersedes #256.