Skip to content

Commit

Permalink
THEMES-1224 Logical Properties on Ad-Block (#1848)
Browse files Browse the repository at this point in the history
* added logical properties to add block

* updated border-radius to use logical properties
blakeganderson authored Dec 12, 2023
1 parent 8bf3fb7 commit 68f21c7
Showing 4 changed files with 39 additions and 9 deletions.
12 changes: 9 additions & 3 deletions .storybook/themes/news.scss
Original file line number Diff line number Diff line change
@@ -272,12 +272,18 @@
),
"ads-block-admin": (
"background-color": "$global.neutral-7",
"padding": "$global.spacing-4",
"border-radius": var(--border-radius),
"padding-block-start": "$global.spacing-4",
"padding-inline-end": "$global.spacing-4",
"padding-block-end": "$global.spacing-4",
"padding-inline-start": "$global.spacing-4",
"border-start-start-radius": var(--border-radius),
"border-start-end-radius": var(--border-radius),
"border-end-start-radius": var(--border-radius),
"border-end-end-radius": var(--border-radius),
"components": (
"stack": (
"gap": "$global.spacing-4",
"padding-bottom": "$global.spacing-5"
"padding-block-end": "$global.spacing-5"
),
"paragraph": (
"color": "$global.white"
12 changes: 12 additions & 0 deletions blocks/ads-block/index.story.jsx
Original file line number Diff line number Diff line change
@@ -36,3 +36,15 @@ export const adViewWithTopLabel = () => <ArcAdDisplay {...DEFAULT_PROPS} />;
export const adViewHidingTopLabel = () => (
<ArcAdDisplay {...DEFAULT_PROPS} displayAdLabel={false} />
);

export const adminViewRightToLeft = () => (
<div dir="rtl">
<ArcAdDisplay {...DEFAULT_PROPS} isAdmin />
</div>
);

export const adViewWithTopLabelRightToLeft = () => (
<div dir="rtl">
<ArcAdDisplay {...DEFAULT_PROPS} />
</div>
);
12 changes: 9 additions & 3 deletions blocks/ads-block/themes/commerce.json
Original file line number Diff line number Diff line change
@@ -19,12 +19,18 @@
"styles": {
"default": {
"background-color": "$global.neutral-7",
"padding": "$global.spacing-4",
"border-radius": "var(--border-radius)",
"padding-block-start": "$global.spacing-4",
"padding-inline-end": "$global.spacing-4",
"padding-block-end": "$global.spacing-4",
"padding-inline-start": "$global.spacing-4",
"border-start-start-radius": "var(--border-radius)",
"border-start-end-radius": "var(--border-radius)",
"border-end-start-radius": "var(--border-radius)",
"border-end-end-radius": "var(--border-radius)",
"components": {
"stack": {
"gap": "$global.spacing-4",
"padding-bottom": "$global.spacing-5"
"padding-block-end": "$global.spacing-5"
},
"paragraph": {
"color": "$global.white"
12 changes: 9 additions & 3 deletions blocks/ads-block/themes/news.json
Original file line number Diff line number Diff line change
@@ -19,12 +19,18 @@
"styles": {
"default": {
"background-color": "$global.neutral-7",
"padding": "$global.spacing-4",
"border-radius": "var(--border-radius)",
"padding-block-start": "$global.spacing-4",
"padding-inline-end": "$global.spacing-4",
"padding-block-end": "$global.spacing-4",
"padding-inline-start": "$global.spacing-4",
"border-start-start-radius": "var(--border-radius)",
"border-start-end-radius": "var(--border-radius)",
"border-end-start-radius": "var(--border-radius)",
"border-end-end-radius": "var(--border-radius)",
"components": {
"stack": {
"gap": "$global.spacing-4",
"padding-bottom": "$global.spacing-5"
"padding-block-end": "$global.spacing-5"
},
"paragraph": {
"color": "$global.white"

0 comments on commit 68f21c7

Please sign in to comment.