Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THEMES-1224 Logical Properties on Ad-Block #1848

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

blakeganderson
Copy link
Contributor

@blakeganderson blakeganderson commented Dec 12, 2023

Description

This PR updates the logical properties on the article-body-block.

Jira Ticket

Acceptance Criteria

The above logical properties are applied and tested on ad blocks.
Storybook is updated with RTL.

Test Steps

  • Add test steps a reviewer must complete to test this PR
  1. Checkout this branch git checkout THEMES-1224
  2. Run fusion repo with linked blocks npx fusion start -f -l @wpmedia/ads-block
  3. Go to http://localhost/pf/homepage/?_website=the-gazette
  4. Verify it matches the designs in Figma.
  5. Set "textDirection": "rtl" in the "siteProperties" object of the blocks.json.
  6. Restart PageBuilder and verify that the styling adapts to the new text direction.

Effect Of Changes

Before

Example: When I clicked the search button, the button turned red.

[include screenshot or gif or link to video, storybook would be awesome]

After

Example: When I clicked the search button, the button turned green.

[include screenshot or gif or link to video, storybook would be awesome]

Dependencies or Side Effects

Examples of dependencies or side effects are:

Author Checklist

The author of the PR should fill out the following sections to ensure this PR is ready for review.

  • Confirmed all the test steps a reviewer will follow above are working.
  • Confirmed there are no linter errors. Please run npm run lint to check for errors. Often, npm run lint:fix will fix those errors and warnings.
  • Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
  • Confirmed this PR has reasonable code coverage. You can run npm run test:coverage to see your progress.
    • Confirmed this PR has unit test files
    • Ran npm run test, made sure all tests are passing
    • If the amount of work to write unit tests for this change are excessive,
      please explain why (so that we can fix it whenever it gets refactored).
  • Confirmed relevant documentation has been updated/added.

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

  • Linting code actions have passed.
  • Ran the code locally based on the test instructions.
    • I don’t think this is needed to be tested locally. For example, a padding style change (storybook?) or a logic change (write a test).
  • I am a member of the engine theme team so that I can approve and merge this. If you're not on the team, you won't have access to approve and merge this pr.
  • Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.

@blakeganderson blakeganderson added the ready for review The PR author has completed the PR template and is ready for a review label Dec 12, 2023
@blakeganderson blakeganderson requested a review from a team as a code owner December 12, 2023 19:33
Copy link
Contributor

@malavikakoppula malavikakoppula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blakeganderson Just few changes. then this should be good to go

@malavikakoppula malavikakoppula added needs changes The reviewer has requested changes from the PR author and removed ready for review The PR author has completed the PR template and is ready for a review labels Dec 12, 2023
Copy link
Contributor

@malavikakoppula malavikakoppula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malavikakoppula malavikakoppula added ready to merge It's time! Merge this PR. Woo! and removed needs changes The reviewer has requested changes from the PR author labels Dec 12, 2023
@blakeganderson blakeganderson merged commit 68f21c7 into arc-themes-release-version-2.1.3 Dec 12, 2023
@blakeganderson blakeganderson deleted the THEMES-1224 branch December 12, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge It's time! Merge this PR. Woo!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants