Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THEMES-1474: Input display bug #1767

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

vgalatro
Copy link
Contributor

@vgalatro vgalatro commented Nov 2, 2023

Description

Information about what you changed for this PR

Jira Ticket

Acceptance Criteria

The search box should meet the margin size and cover the search icon.

Test Steps

  1. Checkout this branch git checkout THEMES-1474
  2. Checkout arc-themes-components branch git checkout THEMES-1474
  3. Run fusion repo with linked blocks npx fusion start -f -l @wpmedia/search-results-list-block,@wpmedia/identity-block
  4. Add the search results list block to a page, and make sure the input is sized appropriately.
  5. Then check the Identity blocks that use the input component (Log in, sign up, account management) and make sure their inputs are still sized correctly according to the Figma docs.

Effect Of Changes

Before

Screenshot 2023-11-02 at 1 31 34 PM

After

Screenshot 2023-11-02 at 1 31 16 PM

Dependencies or Side Effects

Author Checklist

  • Confirmed all the test steps a reviewer will follow above are working.
  • Confirmed there are no linter errors. Please run npm run lint to check for errors. Often, npm run lint:fix will fix those errors and warnings.
  • Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
  • Confirmed this PR has reasonable code coverage. You can run npm run test:coverage to see your progress.
    • Confirmed this PR has unit test files
    • Ran npm run test, made sure all tests are passing
    • If the amount of work to write unit tests for this change are excessive,
      please explain why (so that we can fix it whenever it gets refactored).
  • Confirmed relevant documentation has been updated/added.

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

  • Linting code actions have passed.
  • Ran the code locally based on the test instructions.
    • I don’t think this is needed to be tested locally. For example, a padding style change (storybook?) or a logic change (write a test).
  • I am a member of the engine theme team so that I can approve and merge this. If you're not on the team, you won't have access to approve and merge this pr.
  • Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.

@vgalatro vgalatro requested a review from a team as a code owner November 2, 2023 17:36
@vgalatro vgalatro added the ready for review The PR author has completed the PR template and is ready for a review label Nov 2, 2023
@nschubach
Copy link
Contributor

@vgalatro
Copy link
Contributor Author

vgalatro commented Nov 7, 2023

@nschubach , do you know the last time that file was updated? I'm seeing nearly every line change when pasting in the newest build from my local. And it's not just the missing commas either (since prettier was removed from the feature pack).

@vgalatro
Copy link
Contributor Author

vgalatro commented Nov 8, 2023

I see why there's so many changes now, didn't realize the quotes on the properties were also being removed by prettier.

@blakeganderson blakeganderson self-assigned this Nov 8, 2023
@blakeganderson blakeganderson added the review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed. label Nov 8, 2023
Copy link
Contributor

@blakeganderson blakeganderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vgalatro vgalatro merged commit 6a1bc94 into arc-themes-release-version-2.1.1 Nov 8, 2023
5 of 6 checks passed
@vgalatro vgalatro deleted the THEMES-1474 branch November 8, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The PR author has completed the PR template and is ready for a review review in progress A review is underway. Even if an approval has been submitted, wait for all reviews to be completed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants