Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THEMES-1474: Input display bug #217

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

vgalatro
Copy link
Contributor

@vgalatro vgalatro commented Nov 2, 2023

Ticket

Description

Components ticket for the input display fix. Blocks ticket is here:

Acceptance Criteria

The search box should meet the margin size and cover the search icon.

Test Steps

See blocks PR: WPMedia/arc-themes-blocks#1767

Author Checklist

  • Confirmed all the test steps a reviewer will follow above are working.
  • Ran this code locally and checked that there are not any unintended side effects. For example, that a CSS selector is scoped only to a particular block.
  • Confirmed relevant documentation has been updated/added.
  • Add label - ready for review when the pull request is ready for someone to begin reviewing

Reviewer Checklist

The reviewer of the PR should copy-paste this template into the review comments on review.

  • All GitHub Actions pass
  • Ran the code locally based on the test instructions.
  • Checked Chromatic for Storybook changes, accepted the updates if acceptable
  • Looked to see that the new or changed code has code coverage, specifically. We want the global code coverage to keep on going up with targeted testing.
  • Approve and Add label - ready to merge if you are happy with the pull request
  • Want another reviewer? Add the label additional review

@vgalatro vgalatro requested a review from a team as a code owner November 2, 2023 17:26
@vgalatro vgalatro added the ready for review The PR author has completed the PR template and is ready for a review label Nov 2, 2023
Copy link
Contributor

@nschubach nschubach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: Merge with other

@nschubach nschubach added do not merge Do not merge, wait to merge this ticket until this label is removed. and removed ready for review The PR author has completed the PR template and is ready for a review labels Nov 7, 2023
@vgalatro vgalatro merged commit 809dde0 into arc-themes-release-version-2.1.1 Nov 8, 2023
1 of 3 checks passed
@vgalatro vgalatro deleted the THEMES-1474 branch November 8, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge, wait to merge this ticket until this label is removed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants