Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: switch deps from stablelib to noble #5333

Open
wants to merge 4 commits into
base: v2.0
Choose a base branch
from

Conversation

paulmillr
Copy link

This has been discussed in https://github.com/orgs/WalletConnect/discussions/4035.

noble is:

  • audited (more audits coming soon)
  • faster
  • smaller
  • used by other libraries (ethers, metamask), which can make them reuse same noble deps
  • popular, issues will be discovered faster

Cross-tests have been added.

Second part of the change: WalletConnect/walletconnect-utils#185

@paulmillr
Copy link
Author

@chris13524 should be ready for the merge.

@chris13524
Copy link
Member

@paulmillr can you resolve conflicts?

@paulmillr
Copy link
Author

@chris13524 done

@paulmillr
Copy link
Author

Tests fixed, now need to run CI again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants