Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structure.json: Add support for new "baseStructDamageExpLevel" option, revert MP structure update #3927

Merged

Conversation

past-due
Copy link
Member

@past-due past-due commented Jun 26, 2024

Basically, this makes #3361 configurable from the structure.json file.

The default "baseStructDamageExpLevel" is 1, and functions as all versions of WZ from 2.0.10-4.4.2 have. With this configuration, structures get the benefit of a hidden experience level damage reduction. (i.e. They get treated as experience level 1, not 0, and the initial calculation before armor is 94% of the base damage value, not 100%.)

To opt-in to explicitly specifying a base experience level for structure damage calculations, add a new "_config_" dict to the top-level structure.json object, specifying the desired "baseStructDamageExpLevel".

Example:

{
  "_config_": {
    "baseStructDamageExpLevel": 0
  },
  ...
}

Would eliminate this default hidden experience level damage reduction for structures.

As it's now possible to configure this from the structure.json, we can now revert the "Structure Update for MP" commit for the 4.5.0 release and just use the prior values with the prior behavior. (Until such time as people find a combination of changes they like.)

past-due and others added 2 commits June 26, 2024 18:35
The default `"baseStructDamageExpLevel"` is `1`, and functions as all versions of WZ from 2.0.10-4.4.2 have. With this configuration, structures get the benefit of a hidden experience level damage reduction. (i.e. They get treated as experience level 1, not 0, and the initial calculation before armor is 94% of the base damage value, not 100%.)

To opt-in to explicitly specifying a base experience level for structure damage calculations, add a new "_config_" dict to the top-level structure.json object, specifying the desired "baseStructDamageExpLevel".

Example:
```json
{
  "_config_": {
    "baseStructDamageExpLevel": 0
  },
  ...
}
```
@past-due past-due added this to the 4.5.0 milestone Jun 26, 2024
@past-due past-due merged commit 02e81cb into Warzone2100:master Jun 27, 2024
37 checks passed
@past-due past-due deleted the 2024_06_struct_dmg_exp_level_calc_1 branch June 27, 2024 02:38
@Iluvalar
Copy link
Contributor

Opt-in stats changes and more things to mod <3
Thank you Past-due!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants